Skip to content

Adding lambda condition to .NET AP #6618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShyamSathish005
Copy link
Contributor

@ekzhu I tried to implement the feature, let me know for further more improvements or clarification

Why are these changes needed?

This PR refactors LambdaTerminationCondition to allow custom lambda expressions for termination, enabling GraphFlow to support custom conditional expressions in edges.

Related issue number

Feature Enhancement #6542.

Checks

@ekzhu
Copy link
Collaborator

ekzhu commented Jun 3, 2025

@ShyamSathish005 I thought we are working on Python API

@ShyamSathish005
Copy link
Contributor Author

Yeah I was working on that, yet I thought I would give it a try this way around

@ekzhu
Copy link
Collaborator

ekzhu commented Jun 4, 2025

I have already created a PR #6623 to address it for the Python API. We need to make a release soon, so I wanted to get this feature across the door quickly.

@ekzhu
Copy link
Collaborator

ekzhu commented Jun 4, 2025

Could you either rename the PR to adding lambda condition to .NET API or close this PR?

@ShyamSathish005
Copy link
Contributor Author

I will change the name

@ShyamSathish005 ShyamSathish005 changed the title Feature/graphflow custom conditional edge Adding lambda condition to .NET AP Jun 5, 2025
@lokitoth
Copy link
Member

lokitoth commented Jun 5, 2025

Since this is only touching .NET code, please do not include changes to uv.lock

@ShyamSathish005
Copy link
Contributor Author

Ok @lokitoth, I will look to it as you said

@ShyamSathish005 ShyamSathish005 requested a review from lokitoth June 5, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants