Consolidate Docker verification for CI workflows#16841
Draft
Conversation
6 tasks
Agent-Logs-Url: https://github.com/microsoft/aspire/sessions/1c0ad5f5-7a4c-462f-9aee-54d5e060c457 Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consolidate verify Docker is running step into a composite action
Consolidate Docker verification for CI workflows
May 6, 2026
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16841Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16841" |
…erify-docker-step
… to start later, delaying other tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up work from the prebuilt CLI E2E Docker image changes. This removes duplicated Docker runner checks, makes the CLI E2E Java image requirement test-owned instead of name-derived, and aligns all CLI E2E image builds on the same buildx path.
Docker verification
.github/actions/verify-docker.CLI E2E Java image gating
requiresPolyglotJavaImageas a CI test property.Aspire.Cli.EndToEnd.Tests.contains(inputs.testShortName, 'Java')with the structural property inrun-tests.yml.--require-java "${{ fromJson(inputs.properties).requiresPolyglotJavaImage == true }}"Image build symmetry
docker buildpath.docker buildx build --loadhelper.Docs and guardrails
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
1s1vsblobprodcus386.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.26208.4/tools/Build.proj /p:Configuration=Debug /p:RepoRoot=/home/REDACTED/work/aspire/aspire/ /p:Restore=false /p:Build=true /p:DotNetBuild=false /p:DotNetBuildSourceOnly=false /p:DotNetBuildFromVMR=false /p:Rebuild=false /p:Test=false(dns block)c78vsblobprodcus322.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false(dns block)/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false .dotnet//bash(dns block)/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.26208.4/tools/Build.proj /p:Configuration=Debug /p:RepoRoot=/home/REDACTED/work/aspire/aspire/ /p:Restore=false /p:Build=true /p:DotNetBuild=false /p:DotNetBuildSourceOnly=false /p:DotNetBuildFromVMR=false /p:Rebuild=false /p:Test=false(dns block)kxqvsblobprodcus376.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false .dotnet//bash(dns block)l49vsblobprodcus358.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false(dns block)/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false .dotnet//bash(dns block)/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.26208.4/tools/Build.proj /p:Configuration=Debug /p:RepoRoot=/home/REDACTED/work/aspire/aspire/ /p:Restore=false /p:Build=true /p:DotNetBuild=false /p:DotNetBuildSourceOnly=false /p:DotNetBuildFromVMR=false /p:Rebuild=false /p:Test=false(dns block)pc2vsblobprodcus360.vsblob.vsassets.io/usr/share/dotnet/dotnet dotnet test --project tests/Infrastructure.Tests/Infrastructure.Tests.csproj --no-launch-profile -- --filter-class *.BuildTestMatrixTests --filter-class *.DockerWorkflowContractTests --filter-not-trait quarantined=true --filter-not-trait outerloop=true(dns block)pkvvsblobprodcus321.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false .dotnet//bash(dns block)u3hvsblobprodcus371.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false .dotnet//bash(dns block)v53vsblobprodcus320.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false .dotnet//bash(dns block)yluvsblobprodcus367.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/sdk/10.0.201/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false .dotnet//bash(dns block)ytvvsblobprodcus310.vsblob.vsassets.io/home/REDACTED/work/aspire/aspire/.dotnet/dotnet /home/REDACTED/work/aspire/aspire/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.26208.4/tools/Build.proj /p:Configuration=Debug /p:RepoRoot=/home/REDACTED/work/aspire/aspire/ /p:Restore=false /p:Build=true /p:DotNetBuild=false /p:DotNetBuildSourceOnly=false /p:DotNetBuildFromVMR=false /p:Rebuild=false /p:Test=false(dns block)If you need me to access, download, or install something from one of these locations, you can either: