[release/13.3] Validate TypeScript AppHosts before startup#16755
Open
aspire-repo-bot[bot] wants to merge 5 commits intorelease/13.3from
Open
[release/13.3] Validate TypeScript AppHosts before startup#16755aspire-repo-bot[bot] wants to merge 5 commits intorelease/13.3from
aspire-repo-bot[bot] wants to merge 5 commits intorelease/13.3from
Conversation
Add a pre-execute runtime hook and use it to run TypeScript type validation before starting or publishing TypeScript AppHosts. Watch mode validates on every restart so startup is not blocked by existing errors while editing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Clarify the PreExecute contract and make Bun typecheck/watch commands use project-local binaries via bun run instead of bun x. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use Yarn run for project-local TypeScript tools so arguments are forwarded correctly, and update the TypeScript publish E2E fixture to use the typed dashboard options shape. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the Kubernetes TypeScript deploy E2E fixture to use the generated withHelm options shape so it passes runtime type validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aspire-repo-bot
Bot
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16755Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16755" |
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Contributor
|
🎬 CLI E2E Test Recordings — 68 recordings uploaded (commit View all recordings
📹 Recordings uploaded automatically from CI run #25350800758 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16689 to release/13.3
/cc @sebastienros
Customer Impact
Testing
Validated locally with dogfood pr.
Risk
Regression?