Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ public static bool IsStopped(this ResourceViewModel resource)
return resource.KnownState is KnownResourceState.Exited or KnownResourceState.Finished or KnownResourceState.FailedToStart;
}

public static bool IsFailedToStart(this ResourceViewModel resource)
{
return resource.KnownState is KnownResourceState.FailedToStart;
}

public static bool IsUnusableTransitoryState(this ResourceViewModel resource)
{
return resource.KnownState is KnownResourceState.Starting or KnownResourceState.Building or KnownResourceState.Waiting or KnownResourceState.Stopping;
Expand Down
6 changes: 5 additions & 1 deletion src/Aspire.Dashboard/Model/ResourceStateViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ private static (Icon icon, Color color) GetStateIcon(ResourceViewModel resource)
/// </remarks>
internal static string GetResourceStateTooltip(ResourceViewModel resource, IStringLocalizer<Columns> loc)
{
if (resource.IsStopped())
if (resource.IsFailedToStart())
{
return loc.GetString(nameof(Columns.StateColumnResourceFailedToStart), resource.ResourceType);
}
else if (resource.IsStopped())
{
if (resource.TryGetExitCode(out var exitCode) && exitCode is not 0)
{
Expand Down
9 changes: 9 additions & 0 deletions src/Aspire.Dashboard/Resources/Columns.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/Aspire.Dashboard/Resources/Columns.resx
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@
<value>{0} is no longer running</value>
<comment>{0} is a resource type</comment>
</data>
<data name="StateColumnResourceFailedToStart" xml:space="preserve">
<value>{0} failed to start</value>
<comment>{0} is a resource type</comment>
</data>
<data name="SourceColumnDisplayCopyCommandToClipboard" xml:space="preserve">
<value>Copy full command to clipboard</value>
</data>
Expand Down
5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.zh-Hans.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Resources/xlf/Columns.zh-Hant.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ public class ResourceStateViewModelTests
[InlineData(
/* state */ "CustomResource", KnownResourceState.Finished, null, null, null,
/* expected output */ $"Localized:{nameof(Columns.StateColumnResourceExited)}:CustomResource", "RecordStop", Color.Info, "Finished")]
// Resource failed to start - should use dedicated message, not "no longer running"
[InlineData(
/* state */ "Container", KnownResourceState.FailedToStart, null, null, null,
/* expected output */ $"Localized:{nameof(Columns.StateColumnResourceFailedToStart)}:Container", "Warning", Color.Warning, "Failed to start")]
[InlineData(
/* state */ "CustomResource", KnownResourceState.FailedToStart, null, null, null,
/* expected output */ $"Localized:{nameof(Columns.StateColumnResourceFailedToStart)}:CustomResource", "Warning", Color.Warning, "Failed to start")]
[InlineData(
/* state */ "Container", KnownResourceState.Unknown, null, null, null,
/* expected output */ "Unknown", "CircleHint", Color.Info, "Unknown")]
Expand Down
Loading