Add password suppression#878
Merged
IEvangelist merged 2 commits intomainfrom May 7, 2026
Merged
Conversation
This password is used in Aspire XML docs, which we copy into this repo as json files. ex. https://github.com/microsoft/aspire/blob/97df4879743ab960d26cedb168306e0907f36ddd/src/Aspire.Hosting.SqlServer/SqlServerServerResource.cs#L118
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CredScan suppression entry to prevent documentation-derived JSON API metadata (copied from Aspire XML docs) from being flagged for containing a placeholder password value.
Changes:
- Add
"password"to.config/CredScanSuppressions.jsonsuppression placeholders. - Document the rationale for suppressing
"password"as a fake credential used in examples.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
16
| "placeholder": "password", | ||
| "_justification": "Another fake password used in documentation examples in database and service connection strings. Not a real credential." | ||
| }, | ||
| { |
IEvangelist
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This password is used in Aspire XML docs, which we copy into this repo as json files.
ex. https://github.com/microsoft/aspire/blob/97df4879743ab960d26cedb168306e0907f36ddd/src/Aspire.Hosting.SqlServer/SqlServerServerResource.cs#L118