Skip to content

.NET: Fix: OpenAI ChatClients do not send entity_id in AgentChatWebEx… #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −2
Open

.NET: Fix: OpenAI ChatClients do not send entity_id in AgentChatWebEx… #2378

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75abe8d
.NET: Fix: OpenAI ChatClients do not send entity_id in AgentChatWebEx…
MD-V Nov 21, 2025
b34e241
Remove using
MD-V Nov 21, 2025
1845116
Merge branch 'main' into main
MD-V Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion dotnet/samples/AgentWebChat/AgentWebChat.Web/OpenAIChatCompletionsAgentClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,20 @@ public async override IAsyncEnumerable<AgentRunResponseUpdate> RunStreamingAsync
};

var openAiClient = new ChatClient(model: "myModel!", credential: new ApiKeyCredential("dummy-key"), options: options).AsIChatClient();
await foreach (var update in openAiClient.GetStreamingResponseAsync(messages, cancellationToken: cancellationToken))

var chatOptions = new ChatOptions()
{
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the C# Sample Code Guidelines, prefer defining variables using explicit types rather than var to help users understand the types involved. Change var chatOptions to ChatOptions chatOptions.

Copilot generated this review using guidance from repository custom instructions.
ConversationId = threadId,
RawRepresentationFactory = _ => new ChatCompletionOptions()
{
Metadata =
{
{ "entity_id", agentName }
}
},
};

await foreach (var update in openAiClient.GetStreamingResponseAsync(messages, options: chatOptions, cancellationToken: cancellationToken))
{
yield return new AgentRunResponseUpdate(update);
}
Expand Down
9 changes: 8 additions & 1 deletion dotnet/samples/AgentWebChat/AgentWebChat.Web/OpenAIResponsesAgentClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ public async override IAsyncEnumerable<AgentRunResponseUpdate> RunStreamingAsync
var openAiClient = new OpenAIResponseClient(model: agentName, credential: new ApiKeyCredential("dummy-key"), options: options).AsIChatClient();
Copy link

@arjendeblok arjendeblok Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also has a problem, because you will have to pass a LLM model in the model name and not the agent name.

This is quite strange that you will have to pass the model and the agent whereas the agent also defines which model to use.

var chatOptions = new ChatOptions()
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the C# Sample Code Guidelines, prefer defining variables using explicit types rather than var to help users understand the types involved. Change var chatOptions to ChatOptions chatOptions.

Copilot generated this review using guidance from repository custom instructions.
{
ConversationId = threadId
ConversationId = threadId,
RawRepresentationFactory = _ => new ResponseCreationOptions()
{
Metadata =
{
{ "entity_id", agentName }
}
},
};

await foreach (var update in openAiClient.GetStreamingResponseAsync(messages, chatOptions, cancellationToken: cancellationToken))
Expand Down