Skip to content

Conversation

@eavanvalkenburg
Copy link
Member

Motivation and Context

Updated aisearch package to use the already registered agent-framework-azure-ai-search
Updated the samples for it and moved them to the context_providers folder
Maintenance on all the import code, which still had some extra language which we no longer use.

Description

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings November 21, 2025 10:33
@markwallace-microsoft markwallace-microsoft added documentation Improvements or additions to documentation python labels Nov 21, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Nov 21, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/core/agent_framework/openai
   _shared.py1001288%63, 69–72, 150, 152, 159, 161, 174, 250, 274
TOTAL15462235284% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
2225 130 💤 0 ❌ 0 🔥 54.197s ⏱️

Copilot finished reviewing on behalf of eavanvalkenburg November 21, 2025 10:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the AI Search package from agent-framework-aisearch to agent-framework-azure-ai-search for consistency with the naming convention used by other Azure packages. It also unifies the import logic across all packages by separating the import path from the package name and standardizing error messages.

  • Renamed package from agent-framework-aisearch to agent-framework-azure-ai-search
  • Updated all imports to use unified agent_framework.azure namespace
  • Standardized import error handling with separate IMPORT_PATH and PACKAGE_NAME constants

Reviewed Changes

Copilot reviewed 32 out of 35 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
python/pyproject.toml Updated workspace dependency from agent-framework-aisearch to agent-framework-azure-ai-search
python/packages/core/pyproject.toml Updated all extra dependency reference to use new package name
python/packages/azure_ai_search/pyproject.toml Renamed package from agent-framework-aisearch to agent-framework-azure-ai-search and updated test/lint targets
python/packages/azure_ai_search/README.md Updated installation instructions with new package name
python/packages/azure_ai_search/LICENSE Added MIT license file
python/packages/azure_ai_search/agent_framework_azure_ai_search/__init__.py Added package initialization with version detection
python/packages/azure_ai_search/agent_framework_azure_ai_search/_search_provider.py Moved module docstring (incorrectly placed after imports)
python/packages/azure_ai_search/tests/test_search_provider.py Updated all patch decorators and imports from agent_framework_aisearch to agent_framework_azure_ai_search
python/samples/getting_started/context_providers/simple_context_provider.py Updated import to use AzureAIClient and improved string formatting
python/samples/getting_started/context_providers/azure_ai_search/azure_ai_with_search_context_semantic.py Unified imports to use agent_framework.azure namespace
python/samples/getting_started/context_providers/azure_ai_search/azure_ai_with_search_context_agentic.py Unified imports to use agent_framework.azure namespace
python/samples/getting_started/context_providers/azure_ai_search/README.md Added comprehensive documentation for Azure AI Search context provider examples
python/samples/getting_started/context_providers/README.md Added overview documentation for all context providers
python/samples/getting_started/agents/azure_ai/README.md Updated file paths to point to relocated search context samples
python/packages/core/agent_framework/azure/__init__.py Updated import mappings to use new package name and separated import path from package name
python/packages/core/agent_framework/azure/__init__.pyi Added type stubs for AzureAISearchContextProvider and AzureAISearchSettings
python/packages/core/agent_framework/redis/__init__.py Standardized import logic with IMPORT_PATH and PACKAGE_NAME separation
python/packages/core/agent_framework/redis/__init__.pyi Reformatted imports and all list
python/packages/core/agent_framework/microsoft/__init__.py Simplified import dictionary from tuple of list to tuple of two strings
python/packages/core/agent_framework/microsoft/__init__.pyi Reformatted imports
python/packages/core/agent_framework/mem0/__init__.py Standardized import logic with IMPORT_PATH and PACKAGE_NAME separation
python/packages/core/agent_framework/mem0/__init__.pyi Reformatted imports and all list
python/packages/core/agent_framework/devui/__init__.py Standardized import logic with IMPORT_PATH and PACKAGE_NAME separation
python/packages/core/agent_framework/devui/__init__.pyi Added blank line after copyright
python/packages/core/agent_framework/chatkit/__init__.py Standardized import logic with IMPORT_PATH and PACKAGE_NAME separation
python/packages/core/agent_framework/chatkit/__init__.pyi Reformatted all list
python/packages/core/agent_framework/anthropic/__init__.py Standardized import logic with IMPORT_PATH and PACKAGE_NAME separation
python/packages/core/agent_framework/anthropic/__init__.pyi Reformatted imports and all list
python/packages/core/agent_framework/ag_ui/__init__.py Standardized import logic with IMPORT_PATH and PACKAGE_NAME separation
python/packages/core/agent_framework/a2a/__init__.py Standardized import logic with IMPORT_PATH and PACKAGE_NAME separation
python/packages/core/agent_framework/a2a/__init__.pyi Reformatted imports and all list
python/packages/core/agent_framework/openai/_shared.py Simplified all list formatting
python/packages/core/agent_framework/_workflows/__init__.pyi Deleted type stub file (appears to be out of sync with .py file)
python/.cspell.json Added "azurefunctions" to spell check dictionary
Comments suppressed due to low confidence (1)

python/packages/azure_ai_search/agent_framework_azure_ai_search/_search_provider.py:113

  • Module docstring should be at the top of the file (after copyright notice), not here after imports. Module docstrings need to be the first statement in a module to be recognized by Python documentation tools and IDEs.

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Nov 24, 2025
Merged via the queue into microsoft:main with commit 9f43108 Nov 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants