Skip to content

Fix app notifications IsSupported method to always return true #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoshiizumiya wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

Fix app notifications IsSupported method to always return true #6479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d4296
Fix app notifications IsSupported method to always return true
hoshiizumiya May 14, 2026
20bddcf
Protect call
hoshiizumiya May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions dev/AppNotifications/AppNotificationManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ namespace winrt::Microsoft::Windows::AppNotifications::implementation

bool AppNotificationManager::IsSupported()
{
static bool isSupported{ !Security::IntegrityLevel::IsElevated() };
static bool isSupported = true;
return isSupported;
}

Expand Down Expand Up @@ -427,14 +427,20 @@ namespace winrt::Microsoft::Windows::AppNotifications::implementation
{
return;
}

bool isCallingPreviewSupported = false;
try
{
isCallingPreviewSupported = winrt::AppNotificationConferencingConfig::IsCallingPreviewSupported();
}
catch(...) {}

auto logTelemetry{ AppNotificationTelemetry::Show::Start(
g_telemetryHelper,
m_appId,
notification.Payload(),
notification.Tag(),
notification.Group(),
winrt::AppNotificationConferencingConfig::IsCallingPreviewSupported()) };
isCallingPreviewSupported) };

THROW_HR_IF(WPN_E_NOTIFICATION_POSTED, notification.Id() != 0);

Expand Down