Windows Identity App Private Preview #87
Conversation
Merging latest
Added usage instructions for .NET apps, Python, and MSIX packaging.
…ppCli into hamza/gui-preview
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Bit hard to follow the app logic code, definitely room for some revisions to better separate logical concerns. Provided some suggestions here to get things started. Excited to see how folks use these tools!
| xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
| mc:Ignorable="d" | ||
| Title="Windows Identity App"> | ||
|
|
There was a problem hiding this comment.
Could be good to make sure to Mica backdrop and update Titlebar etc... @niels9001 any other guidance/suggestions?
| </StackPanel> | ||
|
|
||
| <!-- Pivot Control for App Type --> | ||
| <Pivot x:Name="AppTypePivot" Margin="0,0,0,8" SelectionChanged="AppTypePivot_SelectionChanged"> |
There was a problem hiding this comment.
Pivot is sort of out-dated. Could be more organized to make separate pages for each mode anyway (plus not great to have all the code in MainWindow anyway). So, could update to a SelectorBar or other navigation control controlling a frame or content element (I hear SwitchPresenter from the Toolkit is nice, but I'm biased... 😅).
|
|
||
| <!-- Python PivotItem --> | ||
| <PivotItem Header="Python"> | ||
| <StackPanel> |
There was a problem hiding this comment.
You can use Spacing on panels to minimize custom margin use
| <StackPanel Orientation="Horizontal" Spacing="8" HorizontalAlignment="Center" Margin="0,4,0,0"> | ||
| <TextBlock x:Name="FileNameText" FontSize="16" FontWeight="SemiBold" VerticalAlignment="Center"/> | ||
| <Button x:Name="CancelButton" Width="32" Height="32" Padding="0" FontSize="20" VerticalAlignment="Center" HorizontalAlignment="Center" Background="Transparent" BorderThickness="0" ToolTipService.ToolTip="Remove file"> | ||
| <TextBlock FontFamily="Segoe MDL2 Assets" Text="" VerticalAlignment="Center" HorizontalAlignment="Center"/> |
There was a problem hiding this comment.
Wrong fontfamily, should use the resource SymbolThemeFontFamily.
|
|
||
| private void BindExeName() | ||
| { | ||
| DotNetFileNamePanel.Visibility = SelectedExeName != null ? Visibility.Visible : Visibility.Collapsed; |
There was a problem hiding this comment.
Please use binding for all these over code-behind, will make things a lot easier, I promise!
| <ScrollViewer x:Name="ProgressScrollViewer" VerticalScrollBarVisibility="Auto"> | ||
| <ListView x:Name="ProgressItemsControl"> | ||
| <ListView.ItemTemplate> | ||
| <DataTemplate> |
There was a problem hiding this comment.
Make sure to give data type and use x:Bind
| DotNetProgressPanel.ProgressCards = progressCards; | ||
| PythonProgressPanel.ProgressCards = progressCards; | ||
| MsixProgressPanel.ProgressCards = progressCards; |
There was a problem hiding this comment.
This progresscard pattern was very hard to follow. I think breaking things out into separate pages and trying to better encapsulate the data with MVVM principles and binding would go a long way to make things more readable/maintainable.
Experimental GUI - this is something we want the community's feedback on (the UI-based approach) and is highly experimental in the functionality/code!