Skip to content

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176 to main #62150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

csigs
Copy link
Member

@csigs csigs commented Jul 30, 2025

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176 to main with localized lcls

@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 20:26
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jul 30, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 30, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a localization update pull request that updates diagnostic error message translations across multiple languages. The PR updates TypeScript error messages related to ECMAScript module syntax restrictions in CommonJS modules, improving message clarity and accuracy while adding new diagnostic messages with better guidance for developers.

  • Updates error message translations for module syntax restrictions across 13 languages
  • Replaces "ESM syntax" terminology with more precise "ECMAScript imports and exports" language
  • Adds new diagnostic message with detailed guidance for resolving module syntax conflicts

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Turkish translations for ECMAScript module syntax error messages
src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Russian translations for ECMAScript module syntax error messages
src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Portuguese (Brazil) translations for ECMAScript module syntax error messages
src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Polish translations for ECMAScript module syntax error messages
src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Korean translations for ECMAScript module syntax error messages
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Japanese translations for ECMAScript module syntax error messages
src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Italian translations for ECMAScript module syntax error messages
src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates French translations for ECMAScript module syntax error messages
src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Spanish translations for ECMAScript module syntax error messages
src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates German translations for ECMAScript module syntax error messages
src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Czech translations for ECMAScript module syntax error messages
src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Traditional Chinese translations for ECMAScript module syntax error messages
src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl Updates Simplified Chinese translations for ECMAScript module syntax error messages

<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[A sintaxe ESM não é permitida em um módulo CommonJS quando 'module' estiver definido como 'preserve'.]]></Val>
<Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax".]]></Val>
Copy link
Preview

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "texttimModuleSyntax" appears to be a typo. It should be "verbatimModuleSyntax" to match the English source text.

Suggested change
<Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax".]]></Val>
<Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "verbatimModuleSyntax".]]></Val>

Copilot uses AI. Check for mistakes.

<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[A sintaxe ESM não é permitida em um módulo CommonJS quando a opção "verbatimModuleSyntax" estiver habilitada.]]></Val>
<Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax". Ajuste o campo "type" no "package.json" mais próximo para tornar esse arquivo um módulo ECMAScript ou ajuste as configurações "texttimModuleSyntax", "module" e "moduleResolution" no TypeScript.]]></Val>
Copy link
Preview

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple instances of "texttimModuleSyntax" should be "verbatimModuleSyntax". This typo appears twice in this translation and needs to be corrected.

Suggested change
<Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax". Ajuste o campo "type" no "package.json" mais próximo para tornar esse arquivo um módulo ECMAScript ou ajuste as configurações "texttimModuleSyntax", "module" e "moduleResolution" no TypeScript.]]></Val>
<Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "verbatimModuleSyntax". Ajuste o campo "type" no "package.json" mais próximo para tornar esse arquivo um módulo ECMAScript ou ajuste as configurações "verbatimModuleSyntax", "module" e "moduleResolution" no TypeScript.]]></Val>

Copilot uses AI. Check for mistakes.

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jul 30, 2025
@i-ayushh18
Copy link

🤖 AI Assistant: Task completed: PR #62150: LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176 to...

1 similar comment
@i-ayushh18
Copy link

🤖 AI Assistant: Task completed: PR #62150: LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176 to...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Needs merge
Development

Successfully merging this pull request may close these issues.

4 participants