FIX: prompt_normalizer.send_prompt_async attempts to save duplicate message pieces to memory#1656
Open
behnam-o wants to merge 19 commits intomicrosoft:mainfrom
Open
FIX: prompt_normalizer.send_prompt_async attempts to save duplicate message pieces to memory#1656behnam-o wants to merge 19 commits intomicrosoft:mainfrom
behnam-o wants to merge 19 commits intomicrosoft:mainfrom
Conversation
behnam-o
changed the title
jsong468
approved these changes
Apr 25, 2026
Contributor
jsong468
left a comment
jsong468
left a comment
There was a problem hiding this comment.
seems logical to me! maybe add a unit test to test this
romanlutz
changed the title
romanlutz
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression introduced #1515 , where requests are [attempted to be] written to memory twice, which causes
IntegrityError: UNIQUE constraint failed: PromptMemoryEntries.id
When this line is hit.
The request is already added to memory a few lines above.
A few integration tests are failing because of this (most notably the tests***notebooks ones)