TEST: Add unit tests for prompt_converter_configuration.py#1599
Merged
romanlutz merged 7 commits intomicrosoft:mainfrom Apr 13, 2026
Merged
TEST: Add unit tests for prompt_converter_configuration.py#1599romanlutz merged 7 commits intomicrosoft:mainfrom
romanlutz merged 7 commits intomicrosoft:mainfrom
Conversation
Tests PromptConverterConfiguration init, defaults, and from_converters factory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
apply_defaults registers concrete class names, not abstract base names. Check for 'converter_target' instead of 'PromptConverter.converter_target'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jsong468
approved these changes
Apr 13, 2026
hannahwestra25
approved these changes
Apr 13, 2026
…on.py Co-authored-by: hannahwestra25 <hannahwestra@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the previously untested PromptConverterConfiguration class.
New Test File
tests/unit/prompt_normalizer/test_prompt_converter_configuration.py - 7 tests covering:
Testing
All 7 tests pass locally.