Skip to content

Conversation

iridinite
Copy link
Contributor

Consider a template class with an integer type argument, that has a negative value as default:

template <int C = -1>
class Foo {};

The regex used to look for constants was missing support for the sign, and hence the above example would fail to parse Natvis properly.

@gregg-miskelly gregg-miskelly self-requested a review September 22, 2025 22:47
@gregg-miskelly gregg-miskelly force-pushed the bugfix/natvis-template-constant branch from e5817eb to 91fa397 Compare September 22, 2025 23:10
@gregg-miskelly
Copy link
Member

@iridinite did you sign the license agreement for this one? I think otherwise this one is ready to go. Could just be a problem with the bot.

@iridinite
Copy link
Contributor Author

@gregg-miskelly Hm, that's odd; I didn't interact with the bot after #1396 since the result seems to be cached, not sure why it's hanging now. But yeah, I signed the CLA on behalf of Sony Interactive Entertainment. Let me know if I need to reset it somehow.

Given a class `template <int C = -1> class Foo {};`, negative constants
can be expected in the type name. The regex used to look for constants
was missing support for the sign, and hence the above example would fail
to parse.
@gregg-miskelly gregg-miskelly force-pushed the bugfix/natvis-template-constant branch from 91fa397 to e26e0af Compare September 23, 2025 16:12
@gregg-miskelly
Copy link
Member

@gregg-miskelly Hm, that's odd; I didn't interact with the bot after #1396 since the result seems to be cached, not sure why it's hanging now. But yeah, I signed the CLA on behalf of Sony Interactive Entertainment. Let me know if I need to reset it somehow.

Thanks for confirming! The check reran after I rebased, and it worked this time. So, odd, but at least it went away.

@gregg-miskelly gregg-miskelly merged commit a0e9932 into microsoft:main Sep 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants