Fix anonymous union parsing in Natvis for LLDB #1521
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following example code:
When breaking at the debug trap, the following MI sequence is exchanged when using LLDB-MI (reformatted for readability):
The anonymous union in
Foo
is listed by LLDB-MI as an unnamed child (no expression) and with type nameFoo::(anonymous union)
. The current check for anonymous unions only accounts for the syntax flavor that GDB uses, and so when using LLDB, anonymous unions incorrectly get flagged asNodeType.Field
by MIEngine. This in turn affectsFullName()
which will return an incorrect expression if the members of the union are also compounds.This change ensures that the LLDB flavor of anonymous unions get flagged properly.