Skip to content

Minor code review and CoPilot instructions update #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Minor code review and CoPilot instructions update #243

wants to merge 6 commits into from

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Aug 13, 2025 •
edited
Loading

  • Marked FVF functions noexcept except those that use STL containers.
  • Add 'early out' check to IsValid for release cases where the input might be nul.

windows-2022 image removed 10.0.22000.0 SDK

@walbourn walbourn self-assigned this Aug 13, 2025
@walbourn walbourn requested a review from jonmartinms August 16, 2025 05:19
@walbourn walbourn added the azure_pipelines Pull requests that update Azure DevOps code label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadaOuf nadaOuf Awaiting requested review from nadaOuf

@Andrew-Farrier Andrew-Farrier Awaiting requested review from Andrew-Farrier

@scm-xbox scm-xbox Awaiting requested review from scm-xbox

@jonmartinms jonmartinms Awaiting requested review from jonmartinms

At least 1 approving review is required to merge this pull request.

Assignees

@walbourn walbourn

Labels
azure_pipelines Pull requests that update Azure DevOps code maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@walbourn