Fix update process for DisplayName and Description properties #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2024 19:52
…es actually works. This test fails without the fix in place. Once the fix is applied, it passes. Checks by attempting to update the Description and DisplayName properties, which should create the appropriate traits automatically.
…able. As referenced in the comment, the attReturn positioned value should be set to the newValue which was passed in. Instead, it was just re-writing the existing value. This change fixes that glitch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating
DisplayNameorDescription(the only twolocalizedTraitTable-backed properties), changes were not persisting. It looks like there was a bug in theUpdateConstantValuemethod which caused the original value to be written back onto the property instead of the new value.This change fixes the behavior to act as intended (and as described in the comments which were already on the method).
This change also provides a test which covers this scenario and checks that these two properties update correctly when set through the SDK.