Skip to content

addressing issue #223 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

addressing issue #223 #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
168ae58
addressing issue #223
polatengin Nov 5, 2025
ff7a220
Update .github/workflows/test_terraform.yml
PabloZaiden Nov 10, 2025
a0d21ae
Update .github/workflows/check_pr.yml
PabloZaiden Nov 10, 2025
17c0eae
Merge branch 'main' into main
PabloZaiden Nov 10, 2025
1a4ee3d
Merge branch 'microsoft:main' into main
polatengin Nov 19, 2025
85a6782
ci(check_pr): enhance PR context resolution for issue comments and me…
polatengin Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 91 additions & 12 deletions .github/workflows/check_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
types:
- opened
- synchronize
issue_comment:
types:
- created

permissions:
contents: write
Expand All @@ -18,10 +21,6 @@
group: ${{ format('{0}-{1}-{2}-{3}-{4}', github.workflow, github.event_name, github.ref, github.base_ref || null, github.head_ref || null) }}
cancel-in-progress: true

env:
PR_URL: ${{ github.event.pull_request.html_url }}
PR_NUMBER: ${{ github.event.pull_request.number }}

jobs:
check-should-run:
uses: ./.github/workflows/_allow_workflow_run.yml
Expand All @@ -35,13 +34,71 @@
- name: 🩺 Debug
uses: raven-actions/debug@9dbdeb7eea607a7d73411895c65987e71d59a466 # v1.2.0

- name: 🧠 Resolve PR context
id: pr_context
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
github-token: ${{ github.token }}
script: |
const repoFullName = `${context.repo.owner}/${context.repo.repo}`;
const defaultBranch = context.payload.repository?.default_branch || '';
const defaultRef = (context.ref || '').replace('refs/heads/', '') || defaultBranch;

async function loadPullRequest(number) {
const { data } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: number
});
return data;
}

let pr = null;

if (context.eventName === 'pull_request' || context.eventName === 'pull_request_target') {
pr = context.payload.pull_request;
} else if (context.eventName === 'issue_comment') {
if (!context.payload.issue?.pull_request) {
core.setFailed('Issue comment is not associated with a pull request.');
return;
}
pr = await loadPullRequest(context.payload.issue.number);
} else {
core.setFailed(`Unsupported event for this workflow: ${context.eventName}`);
return;
}

const outputs = {
number: pr?.number?.toString() ?? '',
url: pr?.html_url ?? '',
author_login: pr?.user?.login ?? '',
head_repo: pr?.head?.repo?.full_name ?? repoFullName,
head_ref: pr?.head?.ref ?? defaultRef,
head_sha: pr?.head?.sha ?? context.sha,
base_repo: pr?.base?.repo?.full_name ?? repoFullName,
base_ref: pr?.base?.ref ?? defaultBranch || defaultRef,
base_sha: pr?.base?.sha ?? process.env.GITHUB_BASE_REF ?? context.sha
};

for (const [key, value] of Object.entries(outputs)) {
core.setOutput(key, value || '');
}

- name: 🌐 Export PR metadata
run: |
{
echo "PR_URL=${{ steps.pr_context.outputs.url }}";
echo "PR_NUMBER=${{ steps.pr_context.outputs.number }}";
} >> "$GITHUB_ENV"

- name: ⤵️ Checkout
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ steps.pr_context.outputs.head_repo }}
ref: ${{ steps.pr_context.outputs.head_ref }}
fetch-depth: 0

- name: 🚧 Setup Node

Check failure

Code scanning / CodeQL

Checkout of untrusted code in trusted context High

Potential execution of untrusted code on a privileged workflow (
issue_comment
Loading
)
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: lts/*
Expand All @@ -68,23 +125,23 @@
run: task docs

- name: 🤖 Bot details
if: github.event.pull_request.user.login == 'dependabot[bot]'
if: steps.pr_context.outputs.author_login == 'dependabot[bot]'
id: bot-details
uses: raven-actions/bot-details@b2d5fd6eb98adc0cb67df864daa834849f3a8bc0 # v1.1.0
with:
bot-slug-name: dependabot

- name: 📤 Dependabot auto-commit (docs)
uses: stefanzweifel/git-auto-commit-action@28e16e81777b558cc906c8750092100bbb34c5e3 # v7.0.0
if: github.event.pull_request.user.login == 'dependabot[bot]'
if: steps.pr_context.outputs.author_login == 'dependabot[bot]'
with:
commit_message: "docs: automatic updates"
commit_user_name: ${{ steps.bot-details.outputs.name }}
commit_user_email: ${{ steps.bot-details.outputs.email }}
commit_options: "--no-verify --signoff"

- name: 🔀 Check for differences
if: github.event.pull_request.user.login != 'dependabot[bot]'
if: steps.pr_context.outputs.author_login != 'dependabot[bot]'
run: |
git diff --compact-summary --exit-code || \
(echo; echo "🛑 Unexpected difference. Run 'task docs' command and commit."; git diff --exit-code)
Expand All @@ -93,21 +150,43 @@
run: task site:build -- --strict

- name: 📝 Fetch Dependabot metadata
if: github.event.pull_request.user.login == 'dependabot[bot]'
if: steps.pr_context.outputs.author_login == 'dependabot[bot]'
id: dependabot-metadata
uses: dependabot/fetch-metadata@08eff52bf64351f401fb50d4972fa95b9f2c2d1b # v2.4.0
with:
alert-lookup: true
compat-lookup: true

- name: 🏷️ Label (security)
if: github.event.pull_request.user.login == 'dependabot[bot]' && (steps.dependabot-metadata.outputs.ghsa-id != '' || steps.dependabot-metadata.outputs.cvss != 0)
if: steps.pr_context.outputs.author_login == 'dependabot[bot]' && (steps.dependabot-metadata.outputs.ghsa-id != '' || steps.dependabot-metadata.outputs.cvss != 0)
run: gh pr edit --add-label "area/security" "${PR_URL}"
env:
GITHUB_TOKEN: ${{ github.token }}

- name: 🤝 Enable auto-merge
if: github.event.pull_request.user.login == 'dependabot[bot]'
if: steps.pr_context.outputs.author_login == 'dependabot[bot]'
run: gh pr merge --auto --squash "${PR_URL}"
env:
GITHUB_TOKEN: ${{ github.token }}

check_pr_status:
if: always()
name: Check PR Status
needs: [check-should-run, check_pr]
runs-on: ubuntu-24.04
steps:
- name: 🚫 Not Allowed to Run
if: needs.check-should-run.outputs.should_run != 'true'
run: |
if [ "${{ github.event_name }}" = "issue_comment" ]; then
echo "Workflow triggered by issue comment without /allow approval. Skipping without failure." && exit 0
fi
echo "::error::Workflow was not allowed to run. For fork PRs, a maintainer must approve tests with the /allow command."
exit 1

- name: 🛑 Failure
if: ${{ needs.check-should-run.outputs.should_run == 'true' && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')) }}
run: exit 1

- name: ✅ Success
run: exit 0
77 changes: 75 additions & 2 deletions .github/workflows/test_terraform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,78 @@ jobs:
runs-on: ubuntu-24.04
outputs:
src: ${{ steps.dirs.outputs.changes }}
pr_number: ${{ steps.pr_context.outputs.number }}
head_repo: ${{ steps.pr_context.outputs.head_repo }}
head_ref: ${{ steps.pr_context.outputs.head_ref }}
head_sha: ${{ steps.pr_context.outputs.head_sha }}
base_sha: ${{ steps.pr_context.outputs.base_sha }}
steps:
- name: 🩺 Debug
uses: raven-actions/debug@9dbdeb7eea607a7d73411895c65987e71d59a466 # v1.2.0

- name: 🧠 Resolve PR context
id: pr_context
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
github-token: ${{ github.token }}
script: |
const repoFullName = `${context.repo.owner}/${context.repo.repo}`;
const defaultBranch = context.payload.repository?.default_branch || 'main';
const defaultRef = (context.ref || '').replace('refs/heads/', '') || defaultBranch;

async function loadPullRequest(number) {
const { data } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: number
});
return data;
}

let pr = null;

if (context.eventName === 'pull_request' || context.eventName === 'pull_request_target') {
pr = context.payload.pull_request;
} else if (context.eventName === 'issue_comment') {
if (context.payload.issue?.pull_request) {
pr = await loadPullRequest(context.payload.issue.number);
}
} else if (context.eventName === 'merge_group') {
const mgPr = context.payload.merge_group?.pull_requests?.[0]?.number;
if (mgPr) {
pr = await loadPullRequest(mgPr);
}
}

const outputs = {
number: pr?.number?.toString() ?? '',
url: pr?.html_url ?? '',
author_login: pr?.user?.login ?? '',
head_repo: pr?.head?.repo?.full_name ?? repoFullName,
head_ref: pr?.head?.ref ?? defaultRef,
head_sha: pr?.head?.sha ?? context.sha,
base_repo: pr?.base?.repo?.full_name ?? repoFullName,
base_ref: pr?.base?.ref ?? defaultBranch,
base_sha: pr?.base?.sha ?? process.env.GITHUB_BASE_REF ?? context.sha
};

for (const [key, value] of Object.entries(outputs)) {
core.setOutput(key, value || '');
}

- name: ⤵️ Checkout
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
with:
repository: ${{ steps.pr_context.outputs.head_repo || github.repository }}
ref: ${{ steps.pr_context.outputs.head_ref || github.ref }}
fetch-depth: 0

- name: 🗃️ Filter
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: filter
with:
base: ${{ github.event_name == 'workflow_dispatch' && github.ref || '' }}
base: ${{ steps.pr_context.outputs.base_sha != '' && steps.pr_context.outputs.base_sha || (github.event_name == 'workflow_dispatch' && github.ref || '') }}
ref: ${{ steps.pr_context.outputs.head_sha != '' && steps.pr_context.outputs.head_sha || '' }}
list-files: csv
filters: |
src:
Expand Down Expand Up @@ -151,6 +211,10 @@ jobs:

- name: ⤵️ Checkout
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
with:
repository: ${{ needs.changes.outputs.head_repo != '' && needs.changes.outputs.head_repo || github.repository }}
ref: ${{ needs.changes.outputs.head_ref != '' && needs.changes.outputs.head_ref || github.ref }}
fetch-depth: 0

- name: 🚧 Setup Task
uses: arduino/setup-task@b91d5d2c96a56797b48ac1e0e89220bf64044611 # v2.0.0
Expand Down Expand Up @@ -364,8 +428,17 @@ jobs:
needs: [check-should-run, changes, test]
runs-on: ubuntu-24.04
steps:
- name: 🚫 Not Allowed to Run
if: needs.check-should-run.outputs.should_run != 'true'
run: |
if [ "${{ github.event_name }}" = "issue_comment" ]; then
echo "Workflow triggered by issue comment without /allow approval. Skipping without failure." && exit 0
fi
echo "::error::Workflow was not allowed to run. For fork PRs, a maintainer must approve with the /allow command."
exit 1

- name: 🛑 Failure
if: ${{ (needs.changes.outputs.src != '[]' && needs.changes.outputs.src != '') && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')) }}
if: ${{ needs.check-should-run.outputs.should_run == 'true' && (needs.changes.outputs.src != '[]' && needs.changes.outputs.src != '') && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')) }}
run: exit 1

- name: ✅ Success
Expand Down
Loading