[28.x]-Subscription Billing: Items created from Catalogue Items are deleted after deleting a Contract Invoice#7246
Open
v-ajaztabrez wants to merge 1 commit intomicrosoft:releases/28.xfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#626000
Summary
Work Item(s) #626000
Bug 626000: [28.x] [all-e]Subscription Billing: Items created from Catalogue Items are deleted after deleting a Contract Invoice
Fixes #
Added an event subscriber PreventDeletionOfSubscriptionItemOnDelNonStockItem in codeunit Sub. Contracts Item Management (8055), subscribing to Catalog Item Management.OnDelNonStockItemOnAfterCheckRelations.
When the deletion flow reaches the item, the subscriber checks whether the item has a Subscription Option of "Service Commitment Item" or "Invoicing Item". If so, it sets ShouldExit := true, aborting the item deletion and preserving the item for continued use in subscription billing.