Skip to content

Conversation

@ceciliaavila
Copy link
Collaborator

Fixes #712

Description

This PR moves the TeamsAttachmentDownloader class from agents-hosting-extensions-teams project to agents-hosting/app.

Detailed Changes

  • Moved the TeamsAttachmentDownloader class to agents-hosting/app.
  • The TeamsAttachmentDownloader class within the Teams extensions has been marked as obsolete. Its has been extended from the new class, and the previous implementation has been removed.
  • Improved the downloadFile function adding validations, handling errors, an making the logic closer to the one in .NET.
  • Added a channel validation in the downloadFiles function.
  • Added M365Copilot to Channels list.
  • Updated the samples/teams/teamsAttachments sample to use the new class.

Testing

The following images show the teamsAttachments sample working after the changes.
image

Copy link
Contributor

@benbrown benbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

@ceciliaavila
Copy link
Collaborator Author

left a few comments

Hi @benbrown, thanks for the feedback! I answered your comments and applied a small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TeamsAttachmentDownloader to Core

4 participants