Fix agentic user token retrieval for n8n Sample #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the agentic user token retrieval mechanism for the n8n sample agent. The main issue was that the authorization object was incorrectly being retrieved from TurnContext.turnState instead of from the AgentApplication instance. The PR also modernizes the sample by removing unnecessary state management, updating dependencies, and refactoring to use the AgentApplicationBuilder pattern.
Key changes:
- Fixed authorization retrieval to use
agentApplication.authorizationinstead ofturnContext.turnState.get('authorization') - Removed application installation and terms acceptance state management logic
- Refactored agent initialization to use
AgentApplicationBuilderwith fluent configuration pattern
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| nodejs/n8n/sample-agent/src/mcpToolRegistrationService.ts | Fixed agentic user token retrieval by getting authorization from AgentApplication; removed unused Authorization import |
| nodejs/n8n/sample-agent/src/n8nAgent.ts | Removed installation and terms acceptance state management; added AgentApplication parameter to constructor |
| nodejs/n8n/sample-agent/src/agent.ts | Refactored to use AgentApplicationBuilder pattern; removed custom ConversationState interface and message counter logic |
| nodejs/n8n/sample-agent/src/index.ts | Moved adapter retrieval to request handler; improved debug logging output |
| nodejs/n8n/sample-agent/package.json | Updated dependencies to latest versions (@modelcontextprotocol/sdk, dotenv, tsx, etc.) |
| nodejs/n8n/sample-agent/.env.template | Reorganized and added observability configuration; updated auth scope from Agentic to Microsoft Graph |
| nodejs/n8n/sample-agent/Agent-Code-Walkthrough.MD | Updated documentation to reflect removal of state management features |
rbrighenti
force-pushed
the
users/rbrighenti/n8n-fix-agentic-token
branch
from
b9b7b21 to
18977ac
Compare
rbrighenti
force-pushed
the
users/rbrighenti/n8n-fix-agentic-token
branch
from
18977ac to
c3291f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Agentic User Token retrieval in mcpToolRegistrationService.ts by getting the Authorization entity from the Agent Application instead of the TurnContext.
Beyond that I've taken the opportunity to simplify the sample agent, update dependencies and tidy up the environment template file