Skip to content

Fix documentation for Loc.LessThan() and other similar functions #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeKar merged 2 commits into from
Mar 30, 2026
Merged

Fix documentation for Loc.LessThan() and other similar functions #4058

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be75cc
Fix documentation for Loc.LessThan() and other similar functions
bibainet Mar 27, 2026
4ddf4fe
Rewrite Loc.MoveLA(n): do not call util.Abs(n) in cycle, cleaner code
bibainet Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions internal/buffer/loc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,23 @@ type Loc struct {
X, Y int
}

// LessThan returns true if b is smaller
// LessThan returns true if l is smaller than b
func (l Loc) LessThan(b Loc) bool {
if l.Y < b.Y {
return true
}
return l.Y == b.Y && l.X < b.X
}

// GreaterThan returns true if b is bigger
// GreaterThan returns true if l is bigger than b
func (l Loc) GreaterThan(b Loc) bool {
if l.Y > b.Y {
return true
}
return l.Y == b.Y && l.X > b.X
}

// GreaterEqual returns true if b is greater than or equal to b
// GreaterEqual returns true if l is greater than or equal to b
func (l Loc) GreaterEqual(b Loc) bool {
if l.Y > b.Y {
return true
Expand All @@ -36,7 +36,7 @@ func (l Loc) GreaterEqual(b Loc) bool {
return l == b
}

// LessEqual returns true if b is less than or equal to b
// LessEqual returns true if l is less than or equal to b
func (l Loc) LessEqual(b Loc) bool {
if l.Y < b.Y {
return true
Expand Down Expand Up @@ -113,14 +113,13 @@ func (l Loc) left(buf *LineArray) Loc {
// MoveLA moves the cursor n characters to the left or right
// It moves the cursor left if n is negative
func (l Loc) MoveLA(n int, buf *LineArray) Loc {
if n > 0 {
for i := 0; i < n; i++ {
l = l.right(buf)
}
return l
for n > 0 {
l = l.right(buf)
n--
}
for i := 0; i < util.Abs(n); i++ {
for n < 0 {
l = l.left(buf)
n++
}
return l
}
Expand Down
Loading