Add ipv4_prefix and ipv6_prefix options for subnet-based rate limiting#97
Open
jpds wants to merge 2 commits intomholt:masterfrom
Open
Add ipv4_prefix and ipv6_prefix options for subnet-based rate limiting#97jpds wants to merge 2 commits intomholt:masterfrom
jpds wants to merge 2 commits intomholt:masterfrom
Conversation
158bb98 to
6bfe4ec
Compare
Adds per-zone configuration to group rate limit keys by network prefix, allowing IPv6 addresses within the same subnet (e.g. /64) to share a single rate limit bucket. This prevents abuse from clients cycling through random addresses within an IPv6 prefix. Each address family has its own setting (ipv4_prefix, ipv6_prefix) so they can be configured independently. When unset (0), addresses are treated individually as before — no change in default behavior. Closes mholt#23 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6bfe4ec to
5160a82
Compare
|
Thinking if the IPv6 case and the idea of blocking |
Author
|
@kahara It's entirely up to the user to configure whatever (I've also almost never had a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-zone configuration to group rate limit keys by network prefix, allowing IPv6 addresses within the same subnet (e.g. /64) to share a single rate limit bucket. This prevents abuse from clients cycling through random addresses within an IPv6 prefix.
Each address family has its own setting (ipv4_prefix, ipv6_prefix) so they can be configured independently. When unset (0), addresses are treated individually as before — no change in default behavior.
Fixes: #23