Merged
Conversation
Owner
mhamidjamil
commented
Oct 31, 2024
mhamidjamil
commented
- Updates command file
- Update env file variables
- Update ntfy warning channel
…roves error handling
…updates command file
…up for uninitialized pins
…andling, and storage management features
…ocumentation and changes signature to reflect server type
wasey-rao
approved these changes
Mar 23, 2025
|
|
||
| if __name__ == '__main__': | ||
| initialize_gpio() # Blink LED on startup | ||
| app.run(host='0.0.0.0', port=3011) |
Collaborator
There was a problem hiding this comment.
could you please make a list in discussion which let new user know that what is the port sequence like I don't remember which service is on which port so like I think we should follow a sequence for this part @mhamidjamil
@SaffiUllah1999 please let us know if any suggestion
|
|
||
| # Global variables for configuration | ||
| SOURCE_DIR = "/var/lib/motion" | ||
| DEST_DIR = "/mnt/wd/motion" |
Collaborator
There was a problem hiding this comment.
please let me know if this part is working or not as I remember in our discussion, we were facing issues with external hard drive.
Comment on lines
+72
to
+76
| def motion_status(message): | ||
| """to send motion_status""" | ||
| send_to_ntfy("motion_status", message) | ||
| log_message("info", "\n!!!" + message + "!!!\n") | ||
|
|
Collaborator
There was a problem hiding this comment.
please make a separate method which get the channel name and message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.