[1.18.1] Suppressed "Gave 0 [Air]" message when trying to obtain item with full stack of the item already in cursor.

[cjapar2]

Fixes issue #2677.

Added the following if-statement to check if the current stack on the cursor is less than the maximum stack allowed. This makes it so that the game doesn't unnecessarily try to give you more of the item than it can. As a result, the "Give Air" message does not appear in the chat and console log.

if (player.inventoryMenu.getCarried().getCount() < player.inventoryMenu.getCarried().getMaxStackSize()) {
	Network.sendPacketToServer(packet);
}

[CLAassistant]

All committers have signed the CLA.

[mezz]

Thanks for contributing!
Your fix seems to target setHotbarStack, is that really what fixes the bug described in the issue?

Also if you want to fix this in 1.18.2, the normal branch to use is 1.18
I just have the 1.18.1 branch for that specific version but it's not used by many people.

[github-actions]

This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.