Skip to content

Conversation

@mattiuusitalo
Copy link
Contributor

Drawback to this is that the test doesn't exercise the code as fully as more random usage would.

Pro is that we don't get false negatives from CI tests as often.

Fixes #1236

Drawback to this is that the test doesn't exercise the code as fully
as more random usage would.

Pro is that we don't get false negatives from CI tests as often.
@mattiuusitalo
Copy link
Contributor Author

Used this sort of test to see if it works with lots of repetitions. Without the change I get consistently at least one failure per 100 tries.

#!/bin/bash

for i in {0..100}
do
    if clojure -M:test:cljs-test-runner:cherry:test-cherry -c "{:optimizations :none}" -n malli.parser-test 2 >& 1 > /dev/null ; then
       echo "yes"
    else
       echo "failed! on run" $i
       exit
    fi
done

@mattiuusitalo mattiuusitalo merged commit a367e4d into master Nov 12, 2025
16 checks passed
@mattiuusitalo mattiuusitalo deleted the fix-flaky-cljs-test branch November 12, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: parser-info-test

2 participants