Skip to content

[perf] Optimize -parent-child-transformer #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
Merged

[perf] Optimize -parent-child-transformer #1239

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f54f699
[perf] Optimize -parent-child-transformer
alexander-yakushev Nov 10, 2025
0f548f9
[perf] Optimize -parent-child-transformer
alexander-yakushev Nov 10, 2025
1b6845b
Update src/malli/core.cljc
alexander-yakushev Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/malli/core.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,13 @@

(defn -parent-children-transformer [parent children transformer method options]
(let [parent-transformer (-value-transformer transformer parent method options)
child-transformers (into [] (keep #(-transformer % transformer method options)) children)
child-transformer (when (seq child-transformers) (apply -comp (rseq child-transformers)))]
child-transformer
(reduce (fn [acc child]
(let [transformer (-transformer child transformer method options)]
(if (and acc transformer)
(-comp transformer acc)
(or acc transformer))))
nil children)]
(-intercepting parent-transformer child-transformer)))

(defn -map-transformer [ts]
Expand Down