Skip to content

Conversation

@cristeigabriela
Copy link
Contributor

Thank you for contributing to mirrord!

Please make sure you added a CHANGELOG file in changelog.d/ named issue_number.category.md.
For example, 1054.changed.md or +towncrier.added.md (if no issue).

Copy link
Contributor

@itsamegraf itsamegraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I left a few comments. additionally, please make sure CI is green.

@cristeigabriela
Copy link
Contributor Author

@itsamegraf should be ready for next round of review

@itsamegraf
Copy link
Contributor

itsamegraf commented Nov 23, 2025

@itsamegraf should be ready for next round of review

@cristeigabriela
next time please inform me on Slack as well, I could have reviewed this on friday. would have done so even though i was on PTO.

Additionally, please don't hand a pr for review:

  • without CI passing on it - it didn't have any CI run on your last commits
  • with conflicts on the github pr

@itsamegraf itsamegraf force-pushed the win-47-file-filter branch 2 times, most recently from be9fd7b to 2614ff9 Compare November 23, 2025 06:03
@itsamegraf itsamegraf changed the title 𓂃𓏲࣪ win-47 °˖ file filters + file remapper for windows 𓂃𓏲࣪ win-47 °˖ file filters + file remapper for windows (+ WIN-54) Nov 23, 2025
@itsamegraf itsamegraf force-pushed the win-47-file-filter branch 3 times, most recently from c824143 to 6fca1c0 Compare November 23, 2025 14:26
@itsamegraf itsamegraf changed the title 𓂃𓏲࣪ win-47 °˖ file filters + file remapper for windows (+ WIN-54) 𓂃𓏲࣪ win-47 °˖ file filters + file remapper for windows Nov 23, 2025
@itsamegraf
Copy link
Contributor

I attempted to fix the conflicts but had issues and not enough time to fix them.
reverted the PR to the state it was before i started the work.
Please fix the conflicts and get green CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants