🌱 WIP: Add test for quick start guide #1149
Conversation
Signed-off-by: peppi-lotta <[email protected]>
Signed-off-by: peppi-lotta <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
do-not-merge/work-in-progress
peppi-lotta
changed the title
There was a problem hiding this comment.
When I tried to deploy this, bmo was not able to connect to ironic and inspection did not even start. there was error microversions not supported by endpoint in bmo log, which I have really no clue what it means. Something off with network.
I tried to enable tls if that would fix it, but it did not. I still got the same error. Also, I suspect that the bmo kustomization is not configured properly for tls, the bmo deployment did not have reference to ironic certs. I think this patch should be applied if tls were to be enabled.
hack/quick-start-test/bmo/ironic.env
Outdated
| @@ -0,0 +1,3 @@ | |||
| DEPLOY_KERNEL_URL=http://192.168.222.1:6180/images/ironic-python-agent.kernel | |||
| DEPLOY_RAMDISK_URL=http://192.168.222.1:6180/images/ironic-python-agent.initramfs | |||
| IRONIC_ENDPOINT=https://192.168.222.2:6385/v1/ | |||
There was a problem hiding this comment.
https but you have not configured tls for ironic
| networkCIDR: "192.168.222.0/24" | ||
| interface: "eth0" | ||
| ipAddress: "192.168.222.2" | ||
| ipAddressManager: "keepalived" |
There was a problem hiding this comment.
You need to configure the ironic username/password here: apiCredentialsName: ironic-credentials or whatever the secret name is
| secretGenerator: | ||
| - name: ironic-auth | ||
| behavior: create | ||
| files: | ||
| - username=ironic-username | ||
| - password=ironic-password | ||
| type: Opaque |
There was a problem hiding this comment.
I think you can reuse the ironic-credentials defined in bmo kustomization. If you want create own credentials here, you need to make sure they are in baremetal-operator-system namespace as ironic will be there also.
| # Define and start the baremetal-e2e network | ||
| virsh -c qemu:///system net-define net.xml | ||
| virsh -c qemu:///system net-start baremetal-e2e | ||
|
|
||
| if ! sudo virsh net-list --all | grep baremetal-e2e; then | ||
| virsh -c qemu:///system net-define "${REPO_ROOT}/hack/e2e/net.xml" | ||
| virsh -c qemu:///system net-start baremetal-e2e | ||
| fi |
There was a problem hiding this comment.
is REPO_ROOT even defined? The if clause is used the prevent creating the network twice, but as your cleanup script deletes the whole network, maybe it is not needed at all. That is, the whole if-clause can be deleted.
hack/quick-start-test/cleanup.sh
Outdated
| virsh -c qemu:///system net-undefine baremetal-e2e | ||
|
|
||
| export QUICK_START_BASE=${QUICK_START_BASE:="$(dirname -- "$(readlink -f "${BASH_SOURCE[0]}")")"} | ||
| rm -rf "${QUICK_START_BASE}/bmh-vm-01.xml" No newline at end of file |
There was a problem hiding this comment.
Maybe you want to add cleanup for the veth pair and docker network also here, as we define those explicitly. Also the routing rules could be deleted.
ip link del metalend # delete both ends of veth pair
docker network rm kind
iptables -D FORWARD 1
iptables -D FORWARD 1 # twice because we want to remove the first rule twice| resources: | ||
| - https://github.com/metal3-io/baremetal-operator/config/use-irso?ref=main |
There was a problem hiding this comment.
I don't know if this manifest is the reason, but when I deployed this on VM, the variables in ironic.env were not defined. Instead, there was ironic named configmap which probably came from bmo repository where this manifest is located.
We might need to override the configmap so that it uses the ironic.env we provide by adding this to the bmo kustomization:
configMapGenerator:
- name: ironic
behavior: replace
envs:
- ironic.envSigned-off-by: peppi-lotta <[email protected]>
peppi-lotta
force-pushed
the
peppi-lotta/add-test-for-quick-start-guide
branch
from
4b4cc3a to
7ce8153
Compare
3 participants
No description provided.