Skip to content

Conversation

@Rozzii
Copy link
Member

@Rozzii Rozzii commented Oct 20, 2025

This PR:

  • Introduces a new periodic prow job to clean up the IPA proxy cache in nordix artifactory
    • introduces new script to do the cleanup
    • introduces new artifactory token secret
    • introduces new generic artifactory deletion script that utilizes only token authentication

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sunnatillo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Oct 20, 2025

/cc @lentzi90

@Rozzii Rozzii force-pushed the artifactory_cache_cleanup branch from 709f113 to 5fbbfcb Compare October 20, 2025 11:58
@Rozzii
Copy link
Member Author

Rozzii commented Oct 20, 2025

/override metal3-ubuntu-e2e-integration-test-main
Test is not related to the change.

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
Test is not related to the change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one comment below.
Let's test this tomorrow manually before we merge

@Rozzii Rozzii force-pushed the artifactory_cache_cleanup branch 3 times, most recently from 85348be to 26b4226 Compare October 20, 2025 12:23
@Rozzii Rozzii requested a review from lentzi90 October 20, 2025 12:23
@Rozzii
Copy link
Member Author

Rozzii commented Oct 20, 2025

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii Rozzii moved this to MISC WIP in Metal3 - Roadmap Oct 20, 2025
@Rozzii Rozzii force-pushed the artifactory_cache_cleanup branch from 26b4226 to 5aed573 Compare October 20, 2025 12:29
@Rozzii
Copy link
Member Author

Rozzii commented Oct 20, 2025

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii Rozzii force-pushed the artifactory_cache_cleanup branch from 5aed573 to 2b0997a Compare October 20, 2025 12:31
@Rozzii
Copy link
Member Author

Rozzii commented Oct 20, 2025

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This commit:

- Introduces a new periodic prow job to clean up the IPA proxy cache
  in nordix artifactory
  - introduces new script to do the cleanup
  - introduces new artifactory token secret
  - introduces new generic artifactory deletion script that utilizes
    only token authentication

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii Rozzii force-pushed the artifactory_cache_cleanup branch from 2b0997a to a086286 Compare October 21, 2025 07:55
@Rozzii
Copy link
Member Author

Rozzii commented Oct 21, 2025

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Pending testing with @lentzi90

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @Rozzii have you done the test if it works ?

@Rozzii
Copy link
Member Author

Rozzii commented Nov 3, 2025

Looks good to me. @Rozzii have you done the test if it works ?

Still don't have proper token to add to live PROW, maybe this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: MISC WIP

Development

Successfully merging this pull request may close these issues.

5 participants