Skip to content

Conversation

@Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Nov 14, 2025

This PR adds tip to speed up release process to releasing doc.

Fixing issues identified with hack/verify-release.sh script would really speed up release process.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already part of each repositorys docs/releasing.md, not sure if it needs to be duplicated here?

@Sunnatillo
Copy link
Member Author

This is already part of each repositorys docs/releasing.md, not sure if it needs to be duplicated here?

docs/releasing.md is for repo specific. I followed that. For each repo I had to open and wait few PRs until release proceeds. The idea here to check each release branch in each repo at the beginning of release process.

@tuminoid
Copy link
Member

This is already part of each repositorys docs/releasing.md, not sure if it needs to be duplicated here?

docs/releasing.md is for repo specific. I followed that. For each repo I had to open and wait few PRs until release proceeds. The idea here to check each release branch in each repo at the beginning of release process.

I don't see the benefit as its a pre-check for before cutting anything, same as this doc,, but if you feel this benefits someone, then lets merge it.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@Sunnatillo Sunnatillo force-pushed the Sunnatillo/add-tip-to-release-doc branch from bde8b1a to 16963c8 Compare November 17, 2025 09:36
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@metal3-io-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

High-level release process for a major/minor release. For patch releases, only
release the relevant versions.

**TIP**: To speed up the release process, run the `hack/verify-release.sh`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more you edit this, the more I dislike it. The point of verify-release.sh is to make sure something wasn't missed. Its not supposed to be "part" of release process to bump the CVEs etc. All those should've happened as part of normal development process, and the script is just safeguard for verification of that work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sunnatillo
Copy link
Member Author

This is already part of each repositorys docs/releasing.md, not sure if it needs to be duplicated here?

docs/releasing.md is for repo specific. I followed that. For each repo I had to open and wait few PRs until release proceeds. The idea here to check each release branch in each repo at the beginning of release process.

I don't see the benefit as its a pre-check for before cutting anything, same as this doc,, but if you feel this benefits someone, then lets merge it.

I have updated slightly to clarify my point about speeding up the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants