-
Notifications
You must be signed in to change notification settings - Fork 134
Update support matrix and examples for IrSO #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| | Operator version | Ironic version(s) | Default version | | ||
| | ---------------- | ------------------------------ | --------------- | | ||
| | latest (main) | latest, 30.0, 29.0, 28.0, 27.0 | latest | | ||
| | 0.4.0 | 30.0, 29.0, 28.0, 27.0 | 30.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.4.0 still supports latest, it's just not used by default any more
(maybe remove latest from all numbered releases for simplicity?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second the latter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we remove latest from old numbered releases, then we'll have to change the default (in code I mean, not just here)
I'm actually wondering if we should just not support any numbered releases below 0.4.0 at this point, and remove them from the scheme
they're all superseded by 0.4.0 anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have it like this "up to latest" in the Ironic version column, and if at some point we would land a breaking change in the ironic-image then we can just change it to e.g. "up to v40.0" instead of listing all the versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe we remove latest from everywhere except for main. And then add a note that all versions support latest but it's not recommended to use it with any versions or IrSO except for latest.
| | 0.1.0 | latest, 27.0 | latest | | ||
|
|
||
| **NOTE:** the special version value `latest` always installs the latest | ||
| available version of ironic-image and Ironic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like, update this note with "This version value is supported by all releases of IrSO but only works reliably in the latest release."
Signed-off-by: Riccardo Pittau <[email protected]>
51c9418 to
94ec53a
Compare
Rozzii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We have reached a decision on the 2025.07.09 Community meeting.
No description provided.