-
Notifications
You must be signed in to change notification settings - Fork 40
🐛 Fix release-notes in Makefile #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix release-notes in Makefile #786
Conversation
5e0d18b to
84a562a
Compare
b0eed9f to
aedc6c5
Compare
|
/lgtm |
|
I'll take a look tomorrow |
aedc6c5 to
16d228a
Compare
16d228a to
fcd23cd
Compare
Signed-off-by: Peppi-Lotta <[email protected]>
fcd23cd to
7be412a
Compare
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tuminoid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Manually tested, it works as expected.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it: Fix the path release binary is created in. Add more logging and documentation to reduce user error when using release-notes action from Makefile.