🐛 Fix nil pointer issue while checking bootstrapReadyCondition

[kashifest]

We should check if bootstrapReadyCondition is nil or not before checking bootstrapReadyCondition.Status

What this PR does / why we need it:

Fixes #2956

Checklist:

• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• E2E tests have been added, if necessary.
• Integration tests have been added, if necessary.

[kashifest]

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

[kashifest]

@adilGhaffarDev @fmuyassarov @lentzi90 I think this fixes the nil pointer issue as I dont see the error in the controller logs anymore. However, PTAL also yourself and also the worth checking, is it now suppressing any log info.

[Copilot]

Pull Request Overview

This PR fixes nil pointer dereference issues when checking bootstrap and infrastructure ready conditions by adding nil checks before accessing condition properties.

• Added nil checks before accessing Status field on conditions retrieved via Get() method
• Introduced test coverage for the scenario where ConfigRef is defined but the condition is not set

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
controllers/metal3machine_controller.go	Added nil check for infrastructureReadyCondition before accessing its Status field
baremetal/metal3machine_manager.go	Added nil check for bootstrapReadyCondition before accessing its Status field
baremetal/metal3machine_manager_test.go	Added test case to verify behavior when ConfigRef is defined but condition is not set

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lentzi90]

Looks good to me. We will at some point need to add v1beta2 conditions, and then change this so we also check them, but for now I think it is correct.
/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

/lgtm

Backports?

[adilGhaffarDev]

Sorry, it got merged before I had a chance to review it. We need to use sigs.k8s.io/cluster-api/util/deprecated/v1beta1/conditions instead of sigs.k8s.io/cluster-api/util/conditions/deprecated/v1beta1. That should fix the issue.

The difference is:

• util/deprecated/v1beta1/conditions pulls conditions from sigs.k8s.io/cluster-api/api/core/v1beta1.
• util/conditions/deprecated/v1beta1 pulls conditions from sigs.k8s.io/cluster-api/api/core/v1beta2.

Both packages expose v1beta1 conditions, but one sources them from the v1beta1 API and the other from the v1beta2 API. It’s a bit confusing, but this is how CAPI ensures that v1beta1 behavior continues to work during the transition.