Skip to content

Conversation

@tuminoid
Copy link
Member

@tuminoid tuminoid commented Nov 5, 2025

Add AGENTS.md to allow AI assistants to be more effective, especially the Code Review Bot.

Note: do not create .github/copilot-instructions.md as it will prevent current version of Copilot CLI from reading AGENTS.md at all.

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2025
@tuminoid tuminoid force-pushed the tuomo/add-copilot-instructions branch from d66f170 to 0a889e9 Compare November 26, 2025 10:23
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2025
@tuminoid tuminoid force-pushed the tuomo/add-copilot-instructions branch from 0a889e9 to 309198c Compare November 26, 2025 10:26
@tuminoid tuminoid changed the title add copilot-instructions.md 📖 add AGENTS.md Nov 26, 2025
@tuminoid tuminoid marked this pull request as ready for review November 26, 2025 10:27
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
@tuminoid
Copy link
Member Author

/hold
Iterating this in all repos.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@tuminoid tuminoid force-pushed the tuomo/add-copilot-instructions branch 3 times, most recently from 0ea0026 to c232bd0 Compare November 26, 2025 10:56
@tuminoid tuminoid requested a review from Copilot November 26, 2025 10:58
Copilot finished reviewing on behalf of tuminoid November 26, 2025 11:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for AI coding agents working on the Cluster API Provider Metal3 (CAPM3) project. The new AGENTS.md file serves as a detailed reference guide that can be used by AI assistants (including GitHub Copilot and other AI coding tools) to better understand the project's architecture, conventions, and workflows.

Key changes:

  • Comprehensive 1,488-line AGENTS.md file documenting project structure, development workflows, testing guidelines, and coding conventions
  • .github/copilot-instructions.md file that references AGENTS.md using the @ syntax
  • .gitignore entry for .claude directory to exclude AI assistant configuration files

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
AGENTS.md New comprehensive AI agent documentation covering architecture, Makefile targets, CI/CD, code patterns, testing guidelines, E2E testing details, and behavioral guidelines
.gitignore Adds exclusion for .claude directory used by AI assistant configurations
.github/copilot-instructions.md References AGENTS.md to provide context to GitHub Copilot

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tuminoid tuminoid force-pushed the tuomo/add-copilot-instructions branch 2 times, most recently from 0c4b00c to 655805a Compare November 26, 2025 11:41
Add AGENTS.md to allow AI assistants to be more effective, especially
the Code Review Bot.

Note: do not create .github/copilot-instructions.md as it will prevent
current version of Copilot CLI from reading AGENTS.md at all.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid tuminoid force-pushed the tuomo/add-copilot-instructions branch from 655805a to 23e11f2 Compare November 26, 2025 12:28
@tuminoid
Copy link
Member Author

I wonder if the Copilot review would pick it up from PR, now that the copilot-instructions.md mess is cleared up.

Copilot finished reviewing on behalf of tuminoid November 26, 2025 13:43
@tuminoid
Copy link
Member Author

/cc @lentzi90

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants