🚀 Release v1.10.0

[peppi-lotta]

What this PR does / why we need it: Release v1.10.0

[adilGhaffarDev]

Should we wait for this: #2529 to merge?

[adilGhaffarDev]

/hold
For some reason, tests are still using v1.10.0-rc.1 of CAPI, we missed something. I will check.

[adilGhaffarDev]

https://github.com/metal3-io/metal3-dev-env/blob/8cd873825ebf1b7e06e3bf2b76690ff23c625959/lib/releases.sh#L7 This is not working properly; we need to fix it. It's returning v1.10.0-rc.1 even though the latest release v1.10.0.
sort -rV in above function is not sorting according to semantic version, instead just doing simple string sort. I will fix this.

[adilGhaffarDev]

opened the PR: metal3-io/metal3-dev-env#1525
Not sure if it's the best way to solve this, but it works

[tuminoid]

https://github.com/metal3-io/metal3-dev-env/blob/8cd873825ebf1b7e06e3bf2b76690ff23c625959/lib/releases.sh#L7 This is not working properly; we need to fix it. It's returning v1.10.0-rc.1 even though the latest release v1.10.0. sort -rV in above function is not sorting according to semantic version, instead just doing simple string sort. I will fix this.

Yup, -V is not semantic version sort, just a version sort.

Currently v1.10.1 is out and it has solved this problem for us already, but let's merge the fix, as it removes this short window of failure on next cycle.

[tuminoid]

Should we wait for this: #2529 to merge?

It is merged now anyways.

[lentzi90]

I think we should clean this up so that #2517 is listed here and #2432 is put as superseeded

[tuminoid]

This is the one PR that actually has changes. We could combine them "bump to capi v1.10.0" and list both here, but just adding the simple module bump from rc.1 to stable with no other changes would be very misleading IMO.

[lentzi90]

My issue with this is that it looks like we are bumping to a beta release and then in the fine print we are saying that we actually took he proper release. I know the actual changes happened when we took the first pre-release, but it was still superseded by the later proper release. If we would have skipped the pre-release, then we would definitely list the proper release as breaking, right?

[lentzi90]

Sorry now that I read properly I see you suggested to combine them. I like that. It both makes it easy to find the actual changes and shows that we are not on a beta release 👍

[adilGhaffarDev]

Should we wait for this: #2529 to merge?

It is merged now anyways.

@peppi-lotta please update the release notes so it contains #2529 too.

[peppi-lotta]

Let's wait until #2531 is merged then this should be fine to merge.

[tuminoid]

Suggested change

	- Bump CAPI to v1.10.1 (#2531)(#2432)
	- Bump CAPI to v1.10.1 (#2531, #2432)

[peppi-lotta]

/hold cancel

[lentzi90]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

[metal3-io-bot]

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kashifest]

/lgtm