Skip to content

Conversation

@Rozzii
Copy link
Member

@Rozzii Rozzii commented Apr 14, 2025

No description provided.

Signed-off-by: Adam Rozman <[email protected]>
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sunnatillo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Apr 14, 2025

CC release team
/cc @peppi-lotta @elfosardo

@Rozzii
Copy link
Member Author

Rozzii commented Apr 14, 2025

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@Rozzii
Copy link
Member Author

Rozzii commented Apr 14, 2025

/hold
I have to sort out whether the source branch should be on Nordix or on metal3-io

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
- Fix: pulling unused images in the middle of tests (#2271)
- Add use of IPAMprovider to e2e tests (#2348)
- bump golang to 1.23.6 (#2320)
- bump golang to 1.23.5 (#2280)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the bumps bug fixes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are fixing CVEs so in that sense they are

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are bug fixes and are under bug fix title in the (1.9 and 1.8) patch release notes.

## :bug: Bug Fixes

- Fix: pulling unused images in the middle of tests (#2271)
- Add use of IPAMprovider to e2e tests (#2348)
Copy link
Member

@kashifest kashifest Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should perhaps be in others ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Also the one above. We should be more careful when reviewing so that PRs that they get the proper emojis. Any PR that only touches test code should be 🌱

- Bump softprops/action-gh-release from 2.1.0 to 2.2.0 (#2179)
- Bump actions/cache from 4.1.2 to 4.2.0 (#2173)
- add support for 1.10 in e2e (#2164)
- update dependabot config for release-1.9 (#2165)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some superceeded section, please check the previous release notes for this, we dont need to highlight all the bumps here but only the latest ones for each bump.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On IPAM release I got a comment from @tuminoid that beta releases don't need cleaning up... We should probably document what is Metal3 releases official guideline on should betas be cleaned up with superceeded or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thats also fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with not doing the cleanup in beta, for rc we should perhaps already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also ok with that for all these little things, but for the big breaking changes that are reverted I think we may still need to do it. Or at least move them to other or something like this

- Bump CAPI to v1.10.0-beta.0 (#2432)
- Deprecate Metal3data templateReference (#2326)
- Remove IPAM deployment logic (#1993)
- Remove Metal3Machine owner reference from BMH (#1742)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must go in the superseded section because it was reverted

- Fix: pulling unused images in the middle of tests (#2271)
- Add use of IPAMprovider to e2e tests (#2348)
- bump golang to 1.23.6 (#2320)
- bump golang to 1.23.5 (#2280)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are fixing CVEs so in that sense they are

## :bug: Bug Fixes

- Fix: pulling unused images in the middle of tests (#2271)
- Add use of IPAMprovider to e2e tests (#2348)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Also the one above. We should be more careful when reviewing so that PRs that they get the proper emojis. Any PR that only touches test code should be 🌱

@Rozzii
Copy link
Member Author

Rozzii commented Apr 14, 2025

/close

@metal3-io-bot
Copy link
Contributor

@Rozzii: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii Rozzii deleted the release-notes-1.10.0-beta.0 branch April 14, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants