-
Notifications
You must be signed in to change notification settings - Fork 121
🚀 Release v1.10.0-beta.0 #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Release v1.10.0-beta.0 #2494
Conversation
Signed-off-by: Adam Rozman <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
CC release team |
|
/test metal3-centos-e2e-integration-test-main |
|
/hold |
| - Fix: pulling unused images in the middle of tests (#2271) | ||
| - Add use of IPAMprovider to e2e tests (#2348) | ||
| - bump golang to 1.23.6 (#2320) | ||
| - bump golang to 1.23.5 (#2280) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the bumps bug fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are fixing CVEs so in that sense they are
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are bug fixes and are under bug fix title in the (1.9 and 1.8) patch release notes.
| ## :bug: Bug Fixes | ||
|
|
||
| - Fix: pulling unused images in the middle of tests (#2271) | ||
| - Add use of IPAMprovider to e2e tests (#2348) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should perhaps be in others ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Also the one above. We should be more careful when reviewing so that PRs that they get the proper emojis. Any PR that only touches test code should be 🌱
| - Bump softprops/action-gh-release from 2.1.0 to 2.2.0 (#2179) | ||
| - Bump actions/cache from 4.1.2 to 4.2.0 (#2173) | ||
| - add support for 1.10 in e2e (#2164) | ||
| - update dependabot config for release-1.9 (#2165) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need some superceeded section, please check the previous release notes for this, we dont need to highlight all the bumps here but only the latest ones for each bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thats also fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with not doing the cleanup in beta, for rc we should perhaps already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also ok with that for all these little things, but for the big breaking changes that are reverted I think we may still need to do it. Or at least move them to other or something like this
| - Bump CAPI to v1.10.0-beta.0 (#2432) | ||
| - Deprecate Metal3data templateReference (#2326) | ||
| - Remove IPAM deployment logic (#1993) | ||
| - Remove Metal3Machine owner reference from BMH (#1742) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must go in the superseded section because it was reverted
| - Fix: pulling unused images in the middle of tests (#2271) | ||
| - Add use of IPAMprovider to e2e tests (#2348) | ||
| - bump golang to 1.23.6 (#2320) | ||
| - bump golang to 1.23.5 (#2280) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are fixing CVEs so in that sense they are
| ## :bug: Bug Fixes | ||
|
|
||
| - Fix: pulling unused images in the middle of tests (#2271) | ||
| - Add use of IPAMprovider to e2e tests (#2348) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Also the one above. We should be more careful when reviewing so that PRs that they get the proper emojis. Any PR that only touches test code should be 🌱
|
/close |
|
@Rozzii: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.