Skip to content
This repository was archived by the owner on Aug 11, 2025. It is now read-only.

Change Dockerfile image#13

Open
Alva8756 wants to merge 1 commit intomainfrom
docker_file
Open

Change Dockerfile image#13
Alva8756 wants to merge 1 commit intomainfrom
docker_file

Conversation

@Alva8756
Copy link
Copy Markdown
Contributor

@Alva8756 Alva8756 commented Jan 17, 2024

Currently the migration job(create tables to crdb) doesn't take effect.

Job logs only provide limit information: no migrations to run.

It's good to have shell access to either fleetdb or fleetdb-migration pod to investigate deeper. However, existing image gcr.io/distroless/static doesn't support shell :(

They do not contain package managers, shells or any other programs you would expect to find in a standard Linux distribution.
https://github.com/GoogleContainerTools/distroless/blob/main/README.md

We can revert the image back in the future. However it would be helpful for us to switch to some image that allows us debugging inside the pod.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 17, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.72%. Comparing base (c5d78b4) to head (b1c46c6).
⚠️ Report is 105 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          38       38           
  Lines        3732     3732           
=======================================
  Hits         2714     2714           
  Misses        760      760           
  Partials      258      258           
Flag Coverage Δ
unittests 72.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelrebel
Copy link
Copy Markdown
Member

@Alva8756 should we just switch to Alpine so its similar to ConditionOrc, Flasher, Alloy ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants