Only fetch required ips per switch describe instead of all #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
force-pushed
the
only-fetch-required-ips
branch
from
08c19ea to
cf0190d
Compare
Gerrit91
reviewed
Aug 26, 2024
| }) | ||
| }) | ||
|
|
||
| ips := make([]metal.IP, 0) |
Contributor
There was a problem hiding this comment.
Suggested change
| ips := make([]metal.IP, 0) | |
| ips := metal.IPs{} |
majst01
force-pushed
the
only-fetch-required-ips
branch
from
cf0190d to
711fa33
Compare
…o only-fetch-required-ips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During switch describe, which is called from every metal-core every 20 sec, all ips are listed and later filtered by project.
This is a lot of useless data fetched.
This was also found during the dualstack implementation, test was not adopted yet.
TODO: