Repository navigation
Conversation
Clone [rs-port2](https://github.com/hulxv/metacall-rs) to metacall source
viferga
marked this pull request as draft
November 1, 2024 16:29
Member
Contributor
Author
viferga
marked this pull request as ready for review
November 22, 2024 14:53
Member
|
@hulxv I am reopening this one then. |
viferga
marked this pull request as draft
November 22, 2024 14:54
- implement a constructor and `get_value` for - i16, i32, i64 - f32, f64 - String, &str - implement those methods for Value<T>: - `is_null()` - `value_id()` - `value_id_name()`
**Error message:**
```
thread 'value::test::metacall_create_value_str' panicked at src/value/mod.rs:96:9:
assertion `left == right` failed
left: "Hello!\"\u{7}"
right: "Hello!"
```
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the new version of the Rust port for MetaCall, with enhancements, and performance improvements aimed at better integration and usability within the Rust ecosystem.