Retry requests for replication-info in incremental dump code #3668
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been failing with "connection reset by peer" semi-frequently recently.
reosarevok
approved these changes
Nov 12, 2025
Member
reosarevok
left a comment
reosarevok
left a comment
There was a problem hiding this comment.
LGTMBDNT. On the same file, other retry calls have a comment explaining the reasoning; I'm guessing it wouldn't hurt to do the same here? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been failing with "connection reset by peer" semi-frequently recently.
I'm currently testing this inside the production musicbrainz-json-dump container. Edit: No issues to report from the 2025-11-10T17:30:01Z run.