Skip to content

Fix notification system bugs #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2025
Merged

Fix notification system bugs #536

merged 3 commits into from
Nov 10, 2025

Conversation

@fettuccinae
Copy link

@fettuccinae fettuccinae commented Nov 5, 2025 •
edited
Loading

  1. update user_preference orm for notifications_enabled column
  2. add oauth notification scope in table creation script
  3. use musicbrainz_row_id instead of user_id in filter_non_digest_notifications
  4. use recipient from notification table and remove redundant user_email from user_preference table.

@fettuccinae
fix: mb-mail integration bugs
ef3258c 
use musicbrainz_row_id instead of user_id, update user_preference orm for notifications_enabled column and add oauth notification scope in table creation script
@fettuccinae
Copy link
Author

fettuccinae commented Nov 5, 2025

@mayhem -- PR ready for review

mayhem
mayhem approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nitpick to fix.

@mayhem mayhem merged commit 1862c12 into metabrainz:metabrainz-notifications Nov 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayhem mayhem mayhem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fettuccinae @mayhem