Add reply_to, sent_from and recipient columns to notification table. #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication-preference, fix linting issues
…notification information
Merged
mayhem
approved these changes
Oct 9, 2025
Member
mayhem
left a comment
mayhem
left a comment
There was a problem hiding this comment.
Looks good to me, but lets get the previous PR merged, before merging this.
admin/schema_updates/2025-05-12-add-notification-table-and-add-project-types.sql
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, we were directly using this (reply_to, sent_from and recipient) information from the data received by /notification/send endpoint. To use send out HTML mails in digest, we need to store this information in db.
Added reply_to, sent_from, recipient, send_email column in notification table.
Fixed tests for these changes.
Fixed some linting issues.
Refactored notification table related sql migration scripts into one script.