Skip to content

Patch neg eps bug and add test for each accountant - #844

Open
eddiestudies wants to merge 1 commit into
meta-pytorch:mainfrom
eddiestudies:eddiestudies/negative_eps_bug
Open

Patch neg eps bug and add test for each accountant#844
eddiestudies wants to merge 1 commit into
meta-pytorch:mainfrom
eddiestudies:eddiestudies/negative_eps_bug

Conversation

@eddiestudies

Copy link
Copy Markdown
Contributor

Types of changes

Minimal clamping change to avoid returning negative epsilon values(rdp, prv) or failing(gdp)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Issue was raised 585 for prv.
Adds a clamp to avoid negative epsilons for rdp and prv. rdp had a similar negative epsilon issue.
gdp failed because brentq did not find a sign change between [0, 500].

How Has This Been Tested (if it applies)

I added a test that previously failed for the three accountants.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2026
@meta-codesync

meta-codesync Bot commented Aug 18, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D116482979. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant