Fix/pin peft version - #826
Open
MN-NR wants to merge 3 commits into
Open
Conversation
When DataLoader uses WeightedRandomSampler, sample_rate was incorrectly computed from len(data_loader) instead of the true dataset size, causing privacy budget to burn 100x-1000x faster than expected. Fixed by capturing dataset size and batch_size before _prepare_data_loader() replaces the sampler, ensuring privacy accounting uses actual dataset size. Fixes #[813]"
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been imported. If you are a Meta employee, you can view this in D107026628. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
Contributor
|
@MN-NR also this commit's changes seem to have been merged with another commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Motivation and Context / Related issue
Fixes #820
peft 0.14+ breaks Opacus hook registration when used with LoRA (see
issue #820 for full root cause analysis and reproducer). The tutorial
currently does not pin a peft version, causing users to silently
install an incompatible version and hit the bug.
This commit pins peft==0.13.2 in the LoRA tutorial as suggested by
@iden-kalemaj in issue #820, until full compatibility with peft 0.14+
is restored.
Changes
!pip install peft==0.13.2cell intutorials/building_text_classifier.ipynbbefore the LoRA sectionHow Has This Been Tested
Verified peft==0.13.2 imports and LoRA setup works correctly locally: