Use DevX APIs to merge mkeys for CUDA registrations. - #4866
Open
zdevito wants to merge 2 commits into
Open
Conversation
Summary: Standalone `monarch_rdma` Cargo test binaries did not receive the bundled rdma-core archives because `cargo::rustc-link-arg` directives from dependency build scripts do not propagate to final binaries. Emit `rustc-link-search` and `rustc-link-lib` directives instead, order provider archives before `libibverbs`, and expose the existing `rdmaxcel_set_mem_location_id` API through the open-source bindgen configuration. Differential Revision: D119702442
Summary: Remove the QP-based path for creating indirect memory keys over merged memory ranges. Create the merged keys with DevX instead, which supports a much higher number of ranges. Differential Revision: D118726783
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@zdevito has exported this pull request. If you are a Meta employee, you can view the originating Diff in D118726783. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Remove the QP-based path for creating indirect memory keys over merged memory ranges. Create the merged keys with DevX instead, which supports a much higher number of ranges.
Differential Revision: D118726783