Use idle-flush replies for WaitProcs (#4856) - #4856
Open
thomasywang wants to merge 2 commits into
Open
Conversation
Contributor
|
@thomasywang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119564087. |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 12, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 12, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 12, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
thomasywang
force-pushed
the
export-D119564087
branch
from
September 12, 2026 22:24
87b4de1 to
21084b9
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 12, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 12, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
thomasywang
force-pushed
the
export-D119564087
branch
from
September 12, 2026 22:37
21084b9 to
279f6bf
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 12, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
Summary: Migrate `SetClientConfig.reply` to `IdleFlushPortRef` so config acknowledgement barriers retain per-host failure visibility while reducing reply traffic. Differential Revision: D119564085
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
thomasywang
force-pushed
the
export-D119564087
branch
from
September 13, 2026 16:03
279f6bf to
f28a517
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 13, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Sep 13, 2026
Summary: Migrate `WaitProcs.status_reply` to `IdleFlushPortRef` and count every proc update expected from each host destination. Reviewed By: dulinriley Differential Revision: D119564087
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate
WaitProcs.status_replytoIdleFlushPortRefand count every proc update expected from each host destination.Reviewed By: dulinriley
Differential Revision: D119564087