Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Oct 15, 2025

@WillAyd WillAyd marked this pull request as draft October 15, 2025 15:54
releases.json Outdated
"iceberg-cpp": {
"dependency_names": [
"iceberg",
"iceberg_rest",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream it looks like this mistakenly calls meson.override_dependency('iceberg-rest', ...) so need to fix that before release

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think iceberg_rest is far from being finalized. Perhaps add it later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

@WillAyd WillAyd force-pushed the add-iceberg-cpp branch 2 times, most recently from 3f82584 to aa4b4cb Compare October 15, 2025 19:40
@WillAyd
Copy link
Contributor Author

WillAyd commented Oct 16, 2025

I can't reproduce the issue here nor did the meson issue tracker yield anything. The iceberg-cpp default arguments contains:

project(
    'iceberg',
    'cpp',
    version: '0.2.0',
    license: 'Apache-2.0',
    meson_version: '>=1.3.0',
    default_options: [
        'cpp_std=c++23,c++latest',
  ],
)

When I run locally it appears to correctly pass -std=c++23 but in CI I see -std=c++23,c++latest - @eli-schwartz any idea what might be going awry here?

@WillAyd
Copy link
Contributor Author

WillAyd commented Nov 6, 2025

I think the "multiple standard" issue is described upstream in mesonbuild/meson#15202

@bgilbert
Copy link
Collaborator

Please rebase to fix the CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants