interpreter: void holder #9512
Open
interpreter: void holder #9512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9512 +/- ##
=======================================
Coverage 67.33% 67.33%
=======================================
Files 396 398 +2
Lines 85539 85563 +24
Branches 17667 17665 -2
=======================================
+ Hits 57599 57617 +18
- Misses 23255 23261 +6
Partials 4685 4685 ☔ View full report in Codecov by Sentry. |
dcbaker
requested changes
Nov 1, 2021
| @property | ||
| def is_assignable(self) -> bool: | ||
| ''' Property used to indicate whether an object can be used at all ''' | ||
| return True |
There was a problem hiding this comment.
properties are really slow, you generally want to avoid using them if at all possible, I'd make this a class variable instead, set the base class to True, and have the VoidHolder class override it in its class definition.
| @@ -0,0 +1,16 @@ | |||
| # Copyright 2021 The Meson development team | |||
| # SPDX-license-identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Suggested change
| # SPDX-license-identifier: Apache-2.0 | |
| # SPDX-License-Identifier: Apache-2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this refactoring is to slightly simplify the logic in
InterpreterBaseby ensuring that evenNonenow has a corresponding holder. This way we no longer have to check for it and can always assume that we are dealing withInterpreterObjects.