compilers: keep MSVC linker flags out of checks - #16094
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiler.get_compiler_args_for_mode()started including the dynamic linker's always-arguments in 1.11. For MSVC builds, normal targets invokelink.exeseparately, but compiler checks link throughcl.exe. This placed linker-only options such as/releasebefore/link, wherecl.exerejects them with D8043.Keep link-mode compiler-check arguments limited to the MSVC compiler's own always-arguments. The regular link step still receives the dynamic linker's always-arguments through the backend.
The regression test uses the real
MSVCDynamicLinkerand verifies that link-mode compiler arguments do not contain its/releaseoption.Fixes #16086
Tests:
python run_unittests.py InternalTests.test_compiler_args_class_visualstudiopython run_mypy.py mesonbuild/compilers/mixins/visualstudio.pygit diff --check