Add icx (oneAPI DPC++) linking support on Windows - #16069
Open
vlad-perevezentsev wants to merge 9 commits into
Open
Add icx (oneAPI DPC++) linking support on Windows#16069vlad-perevezentsev wants to merge 9 commits into
vlad-perevezentsev wants to merge 9 commits into
Conversation
Member
|
I don't have time ATM, but once the 1.13 cycle starts I'll review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #12470
On Windows with icx (Intel oneAPI DPC++) Meson uses
link.exefor linking butlink.execannot do the SYCL offload step that-fsyclneeds.It just ignores the flag (LNK4044so the program links but the SYCL kernel is missing at runtime.This PR lets
icxdrive the link step itself likeclangandnvccdo so-fsyclworks. Sinceicxuses a clang-cl-like frontend that silently drops unknown MSVC linker flags, those flags are forwarded to the real linker with-Xlinker(close to howCudaCompilerforwards flags tonvcc) while objects and-fsyclstay on theicxside.icxis also treated as MSVC-style for import-lib /.pdbnaming, for/LIBPATH:handling, and for choosing the resource compiler (rcinstead ofwindres).I tested it with
icx 2026.1.1on Windows:A SYCL executable and a SYCL shared library build and run correctly;
run_project_tests.pyshows no new failures compared to master.This is my first PR to Meson. Please let me know if anything should be done differently and I will gladly fix it